Skip to content

fix: Do not call of caching service during routing to check sticky session if not needed#4549

Open
pavel-jares-bcm wants to merge 2 commits intov3.x.xfrom
reboot/fix-sticky-without-cache
Open

fix: Do not call of caching service during routing to check sticky session if not needed#4549
pavel-jares-bcm wants to merge 2 commits intov3.x.xfrom
reboot/fix-sticky-without-cache

Conversation

@pavel-jares-bcm
Copy link
Copy Markdown
Contributor

Description

Linked to #4510
Part of the # (epic)

Type of change

Please delete options that are not relevant.

  • fix: Bug fix (non-breaking change which fixes an issue)
  • feat: New feature (non-breaking change which adds functionality)
  • docs: Change in a documentation
  • refactor: Refactor the code
  • chore: Chore, repository cleanup, updates the dependencies.
  • BREAKING CHANGE or !: Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the style guidelines of this project
  • PR title conforms to commit message guideline ## Commit Message Structure Guideline
  • I have commented my code, particularly in hard-to-understand areas. In JS I did provide JSDoc
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • The java tests in the area I was working on leverage @nested annotations
  • Any dependent changes have been merged and published in downstream modules

For more details about how should the code look like read the Contributing guideline

Signed-off-by: Pavel Jareš <Pavel.Jares@broadcom.com>
@sonarqubecloud
Copy link
Copy Markdown


boolean stickySession = lbTypeIsAuthentication(serviceInstances.iterator().next());
if (!stickySession) {
// service does not support sticky session by userId, just return
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we log some message in debug also for this condition?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Development

Successfully merging this pull request may close these issues.

2 participants